add HWCAP consts AT_HWCAP3 / AT_HWCAP4 #4734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in the Android module cc @maurer |
rustbot
added
O-android
O-linux
O-unix
S-waiting-on-review
stable-nominated
|
At first I thought this was failing in Rust code but then looking at the build logs it is in C code. The AT_HWCAP3/4 consts would not exist in the auxv.h header with older glibc I am guessing is on that Linux system and FreeBSD 13 / 14 would not have this either. |
|
You have to tweak the test in such a case: https://github.com/rust-lang/libc/blob/main/libc-test/build.rs @rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
Thanks. I'll take a look and see if I can figure this out. |
brad0
force-pushed
the
auxv_hwcap
branch
3 times, most recently
from
dcced7b to
b22a5e6
Compare
|
@rustbot ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add HWCAP consts AT_HWCAP3 / AT_HWCAP4.
Sources
https://github.com/bminor/glibc/blob/3ab9b88e2ac91062b6d493fe32bd101a55006c6a/elf/elf.h
https://github.com/freebsd/freebsd-src/blob/85007872d1227006adf2ce119fe30de856cbe12d/sys/sys/elf_common.h
@rustbot label +stable-nominated